fix: Fix URL Search Parameter with falsy value gets omitted

neet · neet · commit 1b2418fe5570 · 2025-04-27T12:03:23.000+09:00
diff --git a/src/adapters/serializers/flatten.spec.ts b/src/adapters/serializers/flatten.spec.ts
@@ -135,4 +135,12 @@ describe("flattenForRailsQueryString", () => {
       `"title=some%20group&context[]=notifications&keywordsAttributes[][keyword]=my%20keyword"`,
     );
   });
+
+  it("encodes an object with value 0", () => {
+    const result = flattenForRailsQueryString({
+      limit: 0,
+    });
+
+    expect(result).toBe("limit=0");
+  });
 });
diff --git a/src/adapters/serializers/flatten.ts b/src/adapters/serializers/flatten.ts
@@ -46,7 +46,7 @@ export const flattenForRailsQueryString = (object: unknown): string => {
   });
 
   return flatten(object)
-    .filter(([, v]) => !!v)
+    .filter(([, v]) => v != undefined)
     .map(([k, v]) => `${k}=${encodeURIComponent(v as string)}`)
     .join("&");
 };
diff --git a/src/adapters/serializers/serializer-native-impl.spec.ts b/src/adapters/serializers/serializer-native-impl.spec.ts
@@ -46,6 +46,14 @@ describe("SerializerNativeImpl", () => {
     );
   });
 
+  it("encodes an object with value 0 to a querystring (#1282)", () => {
+    const data = serializer.serialize("querystring", {
+      limit: 0,
+    });
+
+    expect(data).toBe("limit=0");
+  });
+
   it("parses JSON string to an Object", () => {
     const data = serializer.deserialize("json", '{ "key_name": "value" }');
     expect(data).toEqual({ keyName: "value" });
